Migrate deprecated components from cozy-ui #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (6)
Unchanged files (12)
Total files change -357B -0.01% Groups updated (3)
Unchanged groups (4)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
approved these changes
Jan 23, 2025
| label={t('table.head_thumbnail_size')} | ||
| extension="narrow" | ||
| icon={ | ||
| label={ |
There was a problem hiding this comment.
on perd t('table.head_thumbnail_size') ici non ?
There was a problem hiding this comment.
Dans le principe oui mais il n'étais pas affiché de toute façon à cause du iconOnly
ErrorComponent has been deleted because it is unused (probably a rest from cozy-photos)
Icon was not displayed in a Cozy to Cozy share (it was the only deletion text without icon) because we tried to pass to Icon component an icon that does not exist. And when the deletion text was too long, the icon was shrink to a very small icon. I also adjusted spacing to have better result.
zatteo
force-pushed
the
feat/migrate-deprecated-components
branch
from
809d835 to
6d0de19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated components remaining :
Table=> A lot of refactoring is needed to migrate them. It will be better to do it when we have to work on them.PushClientButton=> Components is deprecated in cozy-ui but still used in Photos and Cozy Pass Web. I do not know what is the best thing to do now : update the component in cozy-ui and remove it from deprecated components or integrate the code directly in the app. It will depends of our next roadmap.